Return 3 vars from load_nifti instead of tuple#12
Open
FelixLiu-SF wants to merge 2 commits intodipy:docker_endpointfrom
Open
Return 3 vars from load_nifti instead of tuple#12FelixLiu-SF wants to merge 2 commits intodipy:docker_endpointfrom
FelixLiu-SF wants to merge 2 commits intodipy:docker_endpointfrom
Conversation
load_nifti returns a tuple and the rest of the code uses the 3rd value which is the nibabel nifti img object. Subsequent calls for the object methods fail. It is probably okay to change to ignore the nibabel object and instead use the data, affine, and other outputs from load_nifti directly, except for gpu_tracker.dump_streamlines uses img.header.get_zooms() which returns a 4-length tuple while load_nifti with return_voxsize=True would return a 3-length tuple; not sure of any implications to .dump_streamlines.
Fix issue when expecting old argument variable fa_numpy. Changed references to fa_file instead and add check for numpy or nifti loading.
Author
|
I also added another fix for the argument name change from fa_numpy to fa_file, and added the code for loading FA in nifti format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_nifti returns a tuple and the rest of the code uses the 3rd value which is the nibabel nifti img object. Subsequent calls for the object methods fail.
It is probably okay to change to ignore the nibabel object and instead use the data, affine, and other outputs from load_nifti directly, except for gpu_tracker.dump_streamlines uses img.header.get_zooms() which returns a 4-length tuple while load_nifti with return_voxsize=True would return a 3-length tuple; not sure of any implications to .dump_streamlines.