Conversation
kyrofa
force-pushed
the
feature/netrc-support
branch
from
0a7b055 to
a9e9a4f
Compare
kyrofa
force-pushed
the
feature/netrc-support
branch
from
d341bc2 to
a9e9a4f
Compare
|
Huh. I'm not sure what I'm doing wrong on the mock bits for earlier pythons. |
kyrofa
force-pushed
the
feature/netrc-support
branch
from
ffd89d0 to
95b8db6
Compare
|
Ah ha, it's an upstream python bug. All fixed now. |
kyrofa
force-pushed
the
feature/netrc-support
branch
2 times, most recently
from
7a1be83 to
042fc24
Compare
As discussed offline it needs to be double checked that this contribution complies with the license. |
`vcs_base.load_url()` currently doesn't support authentication. Add support for both basic and token-based authentication by parsing netrc-formatted files. Use `appdirs` to support vcstool-specific authentication files for both the user and the system (user takes precedence). Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
feature/netrc-support
branch
from
042fc24 to
b7f27ae
Compare
|
Alright, this has been completely redesigned and rewritten from scratch. It does introduce the |
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
Please add some documentation about the new auth files to the README.
(I haven't looked at the test code yet.)
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
feature/netrc-support
branch
from
b494569 to
91f6ad0
Compare
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
feature/netrc-support
branch
from
8b402e4 to
fc361a2
Compare
Done in fc361a2, does that seem to be a sensible place to put it? |
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
I made a few minor edits myself but added some more questions / suggestions inline.
| if e.errno not in (errno.ENOENT, errno.EACCES): | ||
| raise | ||
| except netrc.NetrcParseError: | ||
| # If this file had issues, don't error out so we can try fallbacks |
There was a problem hiding this comment.
Would a warning be more helpful to the user rather then silently ignoring it? On the other hand this behavior might match how other programs using .netrc work.
There was a problem hiding this comment.
We're a little bit in uncharted territory here, to be honest. My inspiration for the design is apt, but one generally runs that as root, so running into permissions issues accessing those files isn't normally an issue. It could be here, if the machine admin only wanted members of a particular group to be able to fetch repositories using these credentials. I had mixed feelings about warning about this or quietly proceeding, so I'm happy adding a warning if you like.
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
For python 2 compatibility. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
|
Gentle ping here. |
|
Hey @dirk-thomas, how are you feeling about this? |
|
@kyrofa / @dirk-thomas is there a reason why this MR was not accepted? |
3 participants
vcs_base.load_url()currently doesn't support authentication. Add support for both basic and token-based authentication by parsing netrc-formatted files. Useappdirsto support vcstool-specific authentication files for both the user and the system (user takes precedence).