Skip to content

Add basic support for activities #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
freya022 wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add basic support for activities #2751

freya022 wants to merge 15 commits into from

Conversation

@freya022
Copy link
Contributor

@freya022 freya022 commented Oct 14, 2024 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Adds basic support for activities:

  • Creating/reading entry point commands (PrimaryEntryPointCommandData)
  • Receiving/responding to entry point interactions (PrimaryEntryPointInteractionEvent)
  • Reading the activity instance (InteractionCallbackResponse#getActivityInstance() from InteractionHook#getCallbackResponse()) created by ILaunchActivityCallback#replyLaunchActivity()
  • Retrieving an activity instance by ID (JDA#retrieveActivityInstanceById(String))

@freya022 freya022 marked this pull request as ready for review October 18, 2024 20:36
DV8FromTheWorld
DV8FromTheWorld reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Dropped a number of comments, but many are duplicates so when a decision is reached all the code is updated.

I think we should consider moving to "PrimaryEntrypointCommand" for a measure of consistency and code-self-explanation.

src/main/java/net/dv8tion/jda/api/JDA.java
@Nonnull
@CheckReturnValue
CommandListUpdateAction updateCommands();
GlobalCommandListUpdateAction updateCommands();
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does renaming this break ABI? I haven't read further here, but this strikes me a possible problem

Copy link
Contributor Author

@freya022 freya022 Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe yes, as the method signatures in the bytecode include the parameters and return type signatures

@freya022 freya022 force-pushed the feature/activities branch from e3f8b06 to 20aa434 Compare August 6, 2025 15:44
@freya022
Copy link
Contributor Author

freya022 commented Aug 6, 2025

I think we should consider moving to "PrimaryEntrypointCommand" for a measure of consistency and code-self-explanation.

Slash command properties are also merged into Command, so I put the entrypoint stuff in it too, having a separate PrimaryEntrypointCommand subtype would require the user to check if it is an instance of such, while for slash commands it isn't needed at this moment. Are you sure you want to go with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld left review comments

Assignees

No one assigned

Labels

type: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freya022 @DV8FromTheWorld @MinnDevelopment