Role-based embargo exemption. #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
commented
Jan 16, 2024
src/Access/QueryTagger.php
Outdated
|
|
||
| // ... the user has a role that is exempted from the embargo. | ||
| $role_alias = $query->leftJoin('embargo__exempt_roles', 'r', 'e.id = %alias.entity_id'); | ||
| $group->condition("{$role_alias}.exempt_roles_target_id",$this->user->getRoles(), 'IN'); |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if I was able to test this query section, but the rest appears to be working.
|
@rosiel Is this a dead PR, or is it still feasible to get this in? While I know there are concerns about scalability, role embargoes would definitely solve some problems for us. |
Contributor
Author
|
is there interest from DGI in merging this? I can work on the conflicts if there is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #27
This lets you specify roles that are exempt from an embargo. This will help with institutional access to content where users may not be forever responsible for individual objects.