Environmental variables fix. Addition of WP_CONFIG_PATH env variable.#112
Open
allan23 wants to merge 1 commit intodisqus:masterfrom
Open
Environmental variables fix. Addition of WP_CONFIG_PATH env variable.#112allan23 wants to merge 1 commit intodisqus:masterfrom
allan23 wants to merge 1 commit intodisqus:masterfrom
Conversation
|
I really would love to see this merged in as well. @ryanvalentin do you think there is any way to get this in timely as currently we will need to manually update every instance of the plugin. If you have any concerns with this approach, please let us know and we'll adjust this accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some servers don't populate the $_ENV variable so environmental variables that are set cannot be read from PHP CLI. So getenv() was added to fetch those variables.
Also, some WP installs do not have wp-config.php in the same directory as index.php, wp-settings.php, etc. Added ability to set WP_CONFIG_PATH environmental variable for those custom setups.