Fix notice on or any page that the $post is not setup as a post object#69
Open
matgargano wants to merge 2 commits intodisqus:masterfrom
matgargano:fix-errors-on-404
Open
Fix notice on or any page that the $post is not setup as a post object#69matgargano wants to merge 2 commits intodisqus:masterfrom matgargano:fix-errors-on-404
matgargano wants to merge 2 commits intodisqus:masterfrom
matgargano:fix-errors-on-404
Conversation
… in dsq_can_replace function and if it doesn't return; this prevents errors that I was getting on my 404 page
matgargano
changed the title
Contributor
Author
|
A little more investigation shows me that this notice comes up on 404 pages (or any pages that never set the post object [$post]). If there's a sidebar with any Loop, on a page like the 404 page this notice will not pop up, since $post was set (at least as far as having a property post_status on it). I discovered this when working with a site with a 404 page that had no instances of a $post object (sidebar or otherwise). |
matgargano
changed the title
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.