Enable integration tests with Daphne Helper#3030
Enable integration tests with Daphne Helper#3030cjpatton wants to merge 1 commit intodivviup:mainfrom
Conversation
Also, remove code for testing against Daphne running locally.
| use url::Url; | ||
|
|
||
| const DAPHNE_HELPER_IMAGE_NAME_AND_TAG: &str = "cloudflare/daphne-worker-helper:sha-f6b3ef1"; | ||
| const DAPHNE_HELPER_IMAGE_NAME_AND_TAG: &str = "cloudflare/daphne-worker-helper:sha-4c612db"; |
There was a problem hiding this comment.
Reviewer note: This tag was created manually. It matches the commit that was checked out when the image was built. In the future we will add publishing the container to CI.
|
@branlwyd can you take a look at the CI failure? It's a bit cryptic: |
|
It actually failed a test further above--this job step just fails the job if a failure as detected earlier. The true error is here https://github.com/divviup/janus/actions/runs/8744950821/job/23999640943?pr=3030#step:14:411, where it complains: n.b. I think the second |
|
The actual error message is a couple steps above, Unpacking the image, I see that both |
|
Ah, nice find. Yeah if you built it locally with |
|
I don't think it would be worth hardcoding a target in the Dockerfile, since the whole base image needs to match the architecture as well, and whatever (docker-)machine is used for building needs to be able to run that architecture. |
|
Ah right, Rust cross-compilation is not as fool-proof as I had hoped, you still need a platform-specific linker. |

Partially addresses #2389.
Also, remove code for testing against Daphne running locally.