Skip to content

DAP-16 Leader Job State Updates #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcjones wants to merge 1 commit into from
Closed

DAP-16 Leader Job State Updates #4324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion aggregator/src/aggregator/aggregation_job_driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,9 +1373,20 @@ where
}),
task_aggregation_counters.clone(),
);

// Determine the next Leader job state based on whether all reports are terminal.
let all_terminal = report_aggregations_to_write
Copy link
Contributor

@tgeoghegan tgeoghegan Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same observations as in #4323: if we're doing this here, we shouldn't do it again in the aggregation job writer. It seems like we consider it a safety net, but we should have enough confidence in our state transitions to avoid redundancy.

.iter()
.all(|ra| ra.is_terminal());
let new_state = if all_terminal {
AggregationJobState::Finished
} else {
AggregationJobState::Active
};

let new_step = aggregation_job.step().increment();
aggregation_job_writer.put(
aggregation_job.with_step(new_step),
aggregation_job.with_step(new_step).with_state(new_state),
report_aggregations_to_write,
)?;
let aggregation_job_writer = Arc::new(aggregation_job_writer);
Expand Down
Loading
Loading