Fixed blog archive headers. #2380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamzap
approved these changes
Dec 17, 2025
blog/tests.py
Outdated
| { | ||
| "view": "weblog:archive-day", | ||
| "kwargs": {"year": year, "month": month, "day": day}, | ||
| "header": "<h1>July 21 archive</h1>", |
Member
There was a problem hiding this comment.
This is probably out of scope, but I wonder if we need to support the day archive view at all. If we do, should we add the year to the header?
Contributor
Author
There was a problem hiding this comment.
Good point! I don't think it makes much sense and I agree about the header
I'll add the year to the header and let the @django/django-website wg discuss if we should just get rid the day archive view in their next meeting 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2220