Launcher bootstrap.xml feature #272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2023
icex2
force-pushed
the
launcher-bootstrap-feature
branch
2 times, most recently
from
99d1c84 to
fb66f0a
Compare
Fill various (minor) gaps in version numbering of ddr distribution packages: * Make A20 and A20+ their own versions to stick to the existing versioning scheme in btools * Add missing distribution bat files for 17 and 18 * Update docs * Name distribution packages accordingly
Used libavs of ddr x3
Used libavs of iidx 18
Used iidx 21 libavs as source
Use the dummy "573" ordinal for now. The method is already listed in avs.h but wasn't used thus far. Require to write some helper/ debug functions to print property node trees from in-memory data, e.g. after modifying them during the boot process.
Caused a lot of headaches until I started to doubt that the correct function is being called... This was tested and works with launcher on ddr x3
AVS version used on ddr-13 and ddr-14-to-18
Mark with 573 ordinal that is not being found to highlight that the ordinal needs to be fixed. The function is being used to implement util/debug plumbing for handling property data in launcher.
Used on ddr x3
Useful to check what's been read into memory and what launcher modified along the way
Ensure we get full visibility about what's going on once the configured logging takes over.
added 7 commits
November 30, 2023 20:40
… log As stated in the comment, having not __type attribute attached, AVS (at least 2.13.6) returns a different value and doesn't treat this as a string by default. Call this "untyped" for now to be able to handle it as a string read on the logging function.
…sions See the comment in the changeset explaining the problem
Assert data that is expected not to be NULL
0xff value terminates a psmap definition, improves readability
The correct one to use is 2.13.06 and not .04. Furthermore, the ordinal of property_node_clone was incorrect which has resulted in odd crashes when using launcher with ddr-13 All other avs API calls were matching and fine though regarding their ordinal mappings
icex2
force-pushed
the
launcher-bootstrap-feature
branch
from
274d4b4 to
530e882
Compare
added 4 commits
November 30, 2023 22:17
Replace placeholder 573 ordinals with ones sourced from actual binaries to make ddr 14-18 work with launcher
See the comment in the changeset. Consider this a sort-of stop gap solution for now until there is more information/ knowledge about the mode flags.
icex2
force-pushed
the
launcher-bootstrap-feature
branch
from
530e882 to
ac13718
Compare
LupinThidr
reviewed
Dec 1, 2023
added 8 commits
December 1, 2023 23:00
Information provided by co-author Co-authored-by: LupinThidr
My local mingw version is newer than that, so everything was considered fine so far.
Use nested structs instead of namespacing with variable names. Adds flexibility to improve modularization of launcher as bootstrap.xml's structure is inheritently providing a structure for having different modules in launcher.
Aligns naming and avoids (personal) confusion
Likely left-over that I forgot to remove
Just moves everything eamuse related from main to a separate module as a first step. Doesn't address ownership of options/config or other stuff such as parameter/config overriding, yet.
This includes dealing with loading the configuration from a file to any kind of mutation of the configuration that launcher needs to do, e.g. injecting ea3-ident or overriding parameters (based on command line params)
Align with naming scheme and avoid using "boot" since this is now being used more like helpers everywhere... so let's go with a generic "util" even that's not great either.
icex2
force-pushed
the
launcher-bootstrap-feature
branch
from
f62aa74 to
b86fe46
Compare
added 4 commits
January 28, 2024 21:28
Continue modularization by separating configuration concerns from the actual module/component.
No need for having extra "context" postfix. It's AVS and launcher sets it up accordingly to make things work
Fits better into the module/context of AVS than the main module of launcher.
icex2
force-pushed
the
launcher-bootstrap-feature
branch
from
2e4a183 to
4798ed8
Compare
Contributor
Author
|
#277 supersedes this PR, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked up the work by @shizmob, driving this my recent work on DDR data and there were a lot more things that required addressing and following-up before this very large new feature can be merged.
Initial PRs that spawned this work, huge thanks for the groundwork, @shizmob: