schema/excluded_schema can be a list #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrobstep
force-pushed
the
master
branch
3 times, most recently
from
13f62b5 to
ebbc2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of introducing multiple schema inclusion/exclusion in migra, I think this could be an addition:
The get_inspector call can now receive schema/exclude_schema as a list, keeping the backward compatibility with passing simple strings. I added
multiple_schemasandexclude_multiple_schemasmethods toPostgreSQL, breaking thefilter_schemassignature compatibility (deep enough in schemainspect that I think breaking it is fine, but that could be adapted). I was tempted to add arguments schemas/exclude_schemas, but didn't in the end.Added the corresponding unit tests, and AFAIK I'm not breaking the existing tests (tested locally on pg 12)
it fixes #68 by @daa