Fix geocode() rate error for source = dsk #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the Google-specific messages and stop errors from displaying when attempting to geocode >2500 or >100000 addresses at once using a non-Google source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 2-line fix for issue #150 allowing address vectors with more than 2500 elements to be geocoded with source = 'dsk'. I ran devtools::check() and roxygen2::roxygenise(".") without any problems.
This method is different from the one in pull request #156 which appears to introduce a bug when the if statement on line 120 is evaluated (if source != 'google' then string s would not exist).
Thanks for the fantastic package!