Add CMake, reformat README.md, rename examples and remove relative include paths#46
Closed
jopadan wants to merge 9 commits intodkfans:masterfrom
jopadan:master
Closed
Add CMake, reformat README.md, rename examples and remove relative include paths#46jopadan wants to merge 9 commits intodkfans:masterfrom jopadan:master
jopadan wants to merge 9 commits intodkfans:masterfrom
jopadan:master
Conversation
dotted
requested changes
Mar 11, 2022
Member
dotted
left a comment
There was a problem hiding this comment.
Wasn't able to build.
Running cmake . && cmake --build . in the root directory I get:
[ 63%] Linking C executable puttrain
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `ceil'
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `acos'
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `sin'
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `sqrt'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/puttrain.dir/build.make:87: puttrain] Error 1
make[1]: *** [CMakeFiles/Makefile2:177: CMakeFiles/puttrain.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
When I run it in the libadikted folder it builds and links just fine.
Trying to tun the command from the mapslang folder gives me:
-- The C compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for one of the modules 'slang'
-- Checking for one of the modules 'libadikted'
CMake Error at /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:707 (message):
None of the required 'libadikted' found
Call Stack (most recent call first):
CMakeLists.txt:27 (pkg_search_module)
-- Configuring incomplete, errors occurred!
See also "/home/dotted/ADiKtEd/mapslang/CMakeFiles/CMakeOutput.log".
Author
|
I've added extra standard C libs to the root directory now. |
Member
|
Continued in #48 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.