Skip to content

Add CMake build system and update README.md#47

Closed
jopadan wants to merge 1 commit intodkfans:masterfrom
jopadan:master
Closed

Add CMake build system and update README.md#47
jopadan wants to merge 1 commit intodkfans:masterfrom
jopadan:master

Conversation

@jopadan
Copy link

@jopadan jopadan commented Mar 15, 2022

No description provided.

@dotted
Copy link
Member

dotted commented Mar 16, 2022

Is there a reason you keep making new pull requests?

@dotted
Copy link
Member

dotted commented Mar 16, 2022

PRs usually get squashed before merge, so don't worry about the commit log. I'll try and build when I get home from work in about 4 hours.

@dotted
Copy link
Member

dotted commented Mar 16, 2022

Doesn't compile, seems you forgot to add the examples to the commit after moving their directories, causing them to be deleted instead.

➜  ADiKtEd git:(pr-47) ✗ git clean -dfX && cmake .
Removing CMakeCache.txt
Removing CMakeFiles/
Removing build/
Removing libadikted/CMakeFiles/
Removing libadikted/libadikted.pc
Removing mapslang/CMakeFiles/
-- The C compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for one of the modules 'slang'
-- Checking for one of the modules 'libadikted'
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found SDL: /usr/lib/x86_64-linux-gnu/libSDLmain.a;/usr/lib/x86_64-linux-gnu/libSDL.so;-lpthread (found version "1.2.15")
-- Configuring done
CMake Error at CMakeLists.txt:36 (add_executable):
  No SOURCES given to target: putemple
Call Stack (most recent call first):
  CMakeLists.txt:67 (add_example)


CMake Error at CMakeLists.txt:36 (add_executable):
  No SOURCES given to target: viewmap
Call Stack (most recent call first):
  CMakeLists.txt:67 (add_example)


CMake Error at CMakeLists.txt:36 (add_executable):
  No SOURCES given to target: puttrain
Call Stack (most recent call first):
  CMakeLists.txt:67 (add_example)


CMake Error at CMakeLists.txt:36 (add_executable):
  No SOURCES given to target: putgems
Call Stack (most recent call first):
  CMakeLists.txt:67 (add_example)


CMake Generate step failed.  Build files cannot be regenerated correctly.

@dotted
Copy link
Member

dotted commented Mar 17, 2022

➜  ADiKtEd git:(pr-47) ✗ git clean -dfX && cmake . && cmake --build .
[...]
[ 63%] Linking C executable puttrain
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `ceil'
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `acos'
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `sin'
/usr/bin/ld: libadikted/libadikted.so: undefined reference to `sqrt'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/puttrain.dir/build.make:87: puttrain] Error 1
make[1]: *** [CMakeFiles/Makefile2:177: CMakeFiles/puttrain.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

@jopadan
Copy link
Author

jopadan commented Mar 27, 2022

I rebased and squashed the commits fixing the mentioned bugs

@jopadan jopadan closed this Mar 28, 2022
@dotted
Copy link
Member

dotted commented Mar 28, 2022

Continued in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants