Update angular-directive-percentage.js#5
Open
thomaswdean wants to merge 1 commit intodkhunt27:masterfrom
Open
Conversation
I removed the check valid check in formatViewDataIntoModelData as this is the new value and we are about to check it's validity and it was interfering with the required directive. Also had a issue with multiple instances of the directive on the same page. I tried an isolate scope but it was still pulling in min and max values from the wrong element. I moved all of the logic into the link method so that each element could store it's own min, max variable values. It seems to be performing as desired now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the check to see if the controller is valid in formatViewDataIntoModelData as this is the newly entered user value and we are about to check it's validity and it was interfering with the required directive. Also had a issue with multiple instances of the directive on the same page. I tried an isolate scope but it was still pulling in min and max values from the wrong element. I moved all of the logic into the link method so that each element could store it's own min, max variable values. It seems to be performing as desired now.