Skip to content

Conversation

@craSH
Copy link

@craSH craSH commented Jul 28, 2023

This PR fixes up the code so it will build with today's versions of Rust and the dependencies needed.

  • Updates all crates to their current versions - getopts was the only neccesary update to properly build with current versions of the Rust toolchain, all others are simply updated as a nice-to-have.
  • Fix panic() string formatting to comply with current/new requirements, per https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html
  • Add the sample JSON input from the readme to the repository, so it's ready to use for testing.

Testing performed for this PR:

These changes both result in a clean and successful build using the current stable and nightly toolchains:

  • stable-aarch64-unknown-linux-gnu / rustc 1.71.0 (8ede3aae2 2023-07-12)
  • nightly-aarch64-unknown-linux-gnu / rustc 1.73.0-nightly (500647fd8 2023-07-27)

craSH added 3 commits July 28, 2023 11:55
Fix panic() string formatting to comply with current/new requirements,
per https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html
This simply adds the sample from the readme to the repository, so it's
ready to use for testing.
- This updates all crates to their current versions.
- getopts was the only neccesary update to properly build with current versions
  of the Rust toolchain.

**Testing:**

These changes both result in a clean and successful build using the
current stable and nightly toolchains:

- stable-aarch64-unknown-linux-gnu / rustc 1.71.0 (8ede3aae2 2023-07-12)
- nightly-aarch64-unknown-linux-gnu / rustc 1.73.0-nightly (500647fd8 2023-07-27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant