[VDO-6041][VDO-6034] Fix saved region and zone count validation#93
Merged
lorelei-sakai merged 1 commit intodm-vdo:mainfrom Feb 23, 2026
Merged
Conversation
Defer zone_count check until the zone_count has been completely computed. (It can depend on the existence of an empty region in the table.) Also validate the region_count to catch cases where too few regions are defined. Signed-off-by: Matthew Sakai <msakai@redhat.com>
lorelei-sakai
changed the title
raeburn
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer zone_count check until the zone_count has been completely computed. (It can depend on the existence of an empty region in the table.) Also validate the region_count to catch cases where too few regions are defined.
As mentioned in vdo-devel, I intend to squash this patch into the first patch in PR #92 and send the combination upstream as v2 of that series.