Collect words into String to reduce number of concats#7
Open
pavlo-liapota wants to merge 1 commit intodmcg:masterfrom
Open
Collect words into String to reduce number of concats#7pavlo-liapota wants to merge 1 commit intodmcg:masterfrom
pavlo-liapota wants to merge 1 commit intodmcg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
permuteIntois generating unique results and we don't need to sort words, so we can go back to your previous way to constructprefix, i.e. have it as aStringinstead ofList<String>. This way we are doing way less string concatenations.Time has reduces from 3500 to 3100.