Llvm adt #13
Merged
Llvm adt #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batches.reserve rows->reserve
…pack 16-bit schema id (precomputed in SchemaRef) and 48-bit node id
dmgcodevil
commented
Sep 16, 2025
| const size_t byte_index = field_index / 8; | ||
| const size_t bit_index = field_index % 8; | ||
| inline void set_field_bit(char* base, size_t idx, bool is_set) { | ||
| auto words = reinterpret_cast<uint64_t*>(base); |
Owner
Author
There was a problem hiding this comment.
better than byte per field
Owner
Author
|
use llvm ADT. use 64 bit word to track fields emty state. precalc fully qualified field names before populate_rows. const uint64_t id =
(static_cast<uint64_t>(schema_id16) << 48) |
(static_cast<uint64_t>(node_id) & NODE_MASK) |
Owner
Author
|
before: duration_optimized=13615 ms after:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.