Skip to content

StringRef ref counting and proper deallocation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmgcodevil merged 2 commits into from
Oct 9, 2025
Merged

StringRef ref counting and proper deallocation #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02aefe2
StringRef ref counting and proper deallocation
dmgcodevil Oct 8, 2025
fa53b3f
formatting
dmgcodevil Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ add_library(core
src/utils.cpp
src/schema.cpp
src/arrow_utils.cpp
src/types.cpp
)

target_include_directories(core
Expand Down
4 changes: 2 additions & 2 deletions include/node_arena.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class NodeArena {

// Deallocate the string if it's not null
if (!str_ref->is_null()) {
string_arena_->deallocate_string(*str_ref);
string_arena_->mark_for_deletion(*str_ref);
}
}
}
Expand Down Expand Up @@ -190,7 +190,7 @@ class NodeArena {
// Logger::get_instance().debug("deallocate old string: {}",
// old_str_ref.to_string());
if (!old_str_ref.is_null()) {
string_arena_->deallocate_string(old_str_ref);
string_arena_->mark_for_deletion(old_str_ref);
}
} catch (...) {
// Old value wasn't a StringRef, ignore
Expand Down
Loading