Skip to content

temporal: node handle + version #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmgcodevil merged 2 commits into from
Jan 15, 2026
Merged

temporal: node handle + version #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3999a
temporal: node handle + version
dmgcodevil Jan 13, 2026
915369a
temporal: GCC-13 available without PPAs
dmgcodevil Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/cmake-single-platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ jobs:
libcds-dev \
llvm clang lldb

# Install GCC 13 (supports C++23)
sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
sudo apt-get update
# Install GCC 13 (available in Ubuntu 24.04 default repos, no PPA needed)
sudo apt-get install -y gcc-13 g++-13
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-13 13 --slave /usr/bin/g++ g++ /usr/bin/g++-13

Expand Down
8 changes: 4 additions & 4 deletions include/node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,10 @@ class NodeManager {
}
}

auto node =
std::make_shared<Node>(id, schema_name, EMPTY_DATA,
std::make_unique<NodeHandle>(node_handle),
node_arena_, schema_, layout_);
auto node = std::make_shared<Node>(
id, schema_name, EMPTY_DATA,
std::make_unique<NodeHandle>(std::move(node_handle)), node_arena_,
schema_, layout_);
nodes[id] = node;
return node;
} else {
Expand Down
Loading