Fix bug

[zhuipiaochen]

I tried to fix some bugs

[GadiZimerman]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Analysis

• 🎯 Main theme: Bug fix in video processing
• 📝 PR summary: This PR addresses several bugs in the video processing code. It modifies the initialization of the video decoder to handle dynamic video format changes, adjusts the calculation of the total frame count, and adds a condition to prevent an infinite loop when parsing corrupted videos. It also updates the parameters of the GetVideoReader function.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 3, because the changes involve critical parts of the video processing code and require a good understanding of the domain to review effectively.
• 🔒 Security concerns: No

PR Feedback

💡 General suggestions: The PR addresses important issues in the video processing code. However, it would be beneficial to add more context or comments in the code to explain the reasons behind the changes. This would help other developers understand the purpose of the changes and their impact on the overall functionality.

🤖 Code feedback:

---

relevant file	src/video/nvcodec/cuda_decoder_impl.cc
suggestion	Consider using a separate function to handle the reinitialization of the decoder when the video format changes. This would improve the readability and maintainability of the code. [important]
relevant line	CHECK_CUDA_CALL(cuvidDestroyDecoder(decoder_));

---

relevant file	src/video/video_reader.cc
suggestion	It would be better to define a constant for the maximum number of iterations (60 in this case) to avoid magic numbers in the code. [medium]
relevant line	if(i > 60){ // This is going to loop indefinitely when parse some corrupted video

---

relevant file	include/decord/video_interface.h
suggestion	It seems like a new parameter 'fault_tol' is added to the GetVideoReader function but it is not used anywhere in the changes. Make sure to use this parameter or remove it if it's not necessary. [medium]
relevant line	int io_type=kNormal, std::string fault_tol="-1");

---

✨ Usage tips:

---

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:

• /review: Request a review of your Pull Request.
• /describe: Update the PR title and description based on the contents of the PR.
• /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
• /ask <QUESTION>: Ask a question about the PR.
• /update_changelog: Update the changelog based on the PR's contents.
• /add_docs 💎: Generate docstring for new components introduced in the PR.
• /generate_labels 💎: Generate labels for the PR based on the PR's contents.
• /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[gaurav274]

@zhuipiaochen, please provide a description of the bugs you fixed in this PR.