Update cuda_decoder_impl.cc

[zhuipiaochen]

When the video format changes, reinitialize the decoder and continue to decode

[zhuipiaochen]

ok

[zhuipiaochen]

ok

[GadiZimerman]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Analysis

• 🎯 Main theme: Handling dynamic video format changes in CUDA video decoder
• 📝 PR summary: This PR modifies the Initialize function in cuda_decoder_impl.cc to handle dynamic video format changes. Instead of stopping the decoding process when the video format changes, the decoder is now reinitialized and continues to decode.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2, because the changes are localized to a single function and the logic is straightforward.
• 🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is generally well done, but it would be beneficial to add error handling after the cuvidDestroyDecoder call. Also, it would be helpful to include tests that simulate dynamic video format changes to ensure the new functionality works as expected.

🤖 Code feedback:

---

relevant file	src/video/nvcodec/cuda_decoder_impl.cc
suggestion	Add error handling after the cuvidDestroyDecoder call. If the decoder fails to be destroyed, it could lead to memory leaks or other unexpected behavior. [important]
relevant line	CHECK_CUDA_CALL(cuvidDestroyDecoder(decoder_));

---

relevant file	src/video/nvcodec/cuda_decoder_impl.cc
suggestion	Consider logging more information about the new format when a dynamic video format change is encountered. This could help with debugging if issues arise in the future. [medium]
relevant line	std::cerr << "Encountered a dynamic video format change.\n";

---

✨ Usage tips:

---

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:

• /review: Request a review of your Pull Request.
• /describe: Update the PR title and description based on the contents of the PR.
• /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
• /ask <QUESTION>: Ask a question about the PR.
• /update_changelog: Update the changelog based on the PR's contents.
• /add_docs 💎: Generate docstring for new components introduced in the PR.
• /generate_labels 💎: Generate labels for the PR based on the PR's contents.
• /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.