Skip to content

Conversation

@latipun7
Copy link

@latipun7 latipun7 commented Jul 15, 2023

This pull request is for automatically creating GitHub release when you push new tag into GitHub. At those times, GitHub actions would run and build this tool into various environments and create GitHub release.
Example release: https://github.com/latipun7/vimv-releases/releases

How to release:

  • go to GitHub Repo SettingsActions tab → General → check Workflow permissions Read and write permissions
  • create local git tag on master branch, i.e. v3.0.0 (git tag "v3.0.0" -m "")
  • push the tag into GitHub (git push --tags)
  • wait for GitHub actions finished with success & automatically release created

Note:

This PR only builds and releases artifacts on GitHub Release. It's not published on crates.io.
This PR also fixes linting and formatting to successfully build and release. Run cargo clippy & cargo fmt --all before commit.

Sorry for the inconvenience

@latipun7 latipun7 marked this pull request as draft July 15, 2023 05:59
@xfzv
Copy link

xfzv commented Jul 17, 2023

Nice! Hopefully this will be merged.

vimv is literally the only tool I install with cargo. With this, I could easily handle updates with chezmoi.

@latipun7 if this is not merged, do you plan on maintaining releases in your own repository in the long run?

@latipun7
Copy link
Author

latipun7 commented Jul 18, 2023

This is still in draft, because I want to build this in android too. But currently this can't be build in android because android didn't has trash method built-in (ref: Byron/trash-rs#10 (comment)).

@dmulholl , do you mind implementing trash as optional feature? Because it seems I have error deleting files in my minimal arch linux wayland too🙏 Here's the reference for what nushell do to resolve this issue:
nushell/nushell#4956

@xfzv , I really do hope this will be maintaining here as this is the original and I would delete my repo. But before there I will maintain mine (https://github.com/latipun7/vimv-releases/releases) because I'm using chezmoi too (https://github.com/latipun7/dotfiles/blob/8401469f579f1c8677d1270a0d729f582f8417b2/home/.chezmoiexternal.yaml#L13) 😁👌 But, for now, no aarch64 android build because the problem I mention before.

@xfzv
Copy link

xfzv commented Jul 18, 2023

I'll use your repo for now then.

Thank you!

@rafo
Copy link

rafo commented Sep 21, 2023

Great work! Since I want to maintain my terminal software in less places (More Homebrew and less PIP, npm, cargo etc.) it would be wonderful to make a Homebrew recipe (I can help).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants