Readbytesb -- return bytes object for efficiency #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardvarkkrill
changed the title
doceme
reviewed
Feb 21, 2019
spidev_module.c
Outdated
| Py_buffer pybuff; | ||
| uint8_t* rxbuf = stackbuf; | ||
|
|
||
| if (resultType == 2) { //existing bytearray |
Owner
There was a problem hiding this comment.
Please remove magic numbers (Add #define for resultType)
doceme
requested changes
Feb 21, 2019
Owner
doceme
left a comment
doceme
left a comment
There was a problem hiding this comment.
Thanks for the PR! I will merge this if you replace the 0, 1, 2 resultType values with #define's.
added 5 commits
February 22, 2019 09:52
Author
|
Good call on the magic numbers. I think perhaps my refactoring is a bit heavy handed anyway, and I've changed it a bit. |
Collaborator
|
Superseded by #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wow ... my first ever pull request! Also my first ever python C-api foray.
So apologies if I've done anything stupid...
added readbytesb which returns a bytes object rather than a list. This can, for example be fed directly into numpy.frombuffer giving more efficient transfer as no list needs to be built.