-
Notifications
You must be signed in to change notification settings - Fork 8.1k
cli: Update docs #23861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cli: Update docs #23861
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Looks like there's some error in the CLI docs: |
| min_api_version: "1.41" | ||
| min_api_version: "1.52" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting; curious if this was some mistake somewhere; let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! never mind this is for docker service, so probably correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope; it is a bug / mistake; looks like some copy/pasta same flag-name repeated here; https://github.com/docker/cli/blob/93fa57bbcd08f2f5be7f6cf22f4273a2b5a49e71/cli/command/service/opts.go#L905-L910
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
08ffb4b to
4065ed0
Compare
|
Actually, gave it a quick try to make a workflow that does this automatically: #23867 |
Description
The cli docs haven't been imported for a while. We should automate this somehow.
Related issues or tickets
Reviews