add registry-login input for optional registry auth before build#117
Open
add registry-login input for optional registry auth before build#117
Conversation
crazy-max
force-pushed
the
registry-login
branch
3 times, most recently
from
1f53313 to
97e2afd
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
registry-login
branch
from
97e2afd to
e36e467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit
registry-logininput to both reusable workflows. It allows logging in to registries before the build step when users need to pull private images even if push isfalseor output is notimage. The input supportsauto,true, andfalse, withautokeeping current behavior by logging in only when output isimageand push istrue. The workflows now validate this input and fail when login is enabled butregistry-authsis not provided.