Reproduce dots in quted names #7031
Conversation
keulinho
force-pushed
the
fix-unquoted-index-names
branch
3 times, most recently
from
8a31939 to
d7ff279
Compare
|
The underlying issue was fixed here: 92dea81 Not sure if it makes sense to add the test case just to not accidentally break the behaviour again anyway I don't know why setting the FK on DB2 and Oracle DBs fails, happy for any insights how to fix |
| public function testIntrospectTableWithDotInIndexNames(): void | ||
| { | ||
| $table = Table::editor() | ||
| ->setQuotedName('test_user') |
There was a problem hiding this comment.
I don't know why setting the FK on DB2 and Oracle DBs fails, happy for any insights how to fix
You declare the table name here as quoted but reference it in the other table as unquoted:
On Oracle and Db2, "test_user" (quoted) remains test_user, while test_user (unquoted) becomes TEST_USER. Hence the error message:
"DB2INST1.TEST_USER" is an undefined name
Unless you want to retain the original case of the name on all platforms, you should use unquoted names.
morozov
force-pushed
the
fix-unquoted-index-names
branch
from
d7ff279 to
83144b1
Compare
Otherwise, an extra "not null" assertion is required before comparing the value returned by OptionallyNamedObject::getObjectName() with the expected one.
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
This pull request was closed due to inactivity. |
3 participants
Summary
Provide test for dots in quoted idx names