Add scripts to deploy multi-cloud telemetry #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgerman
approved these changes
Dec 9, 2025
| unzip /tmp/v${DocumentDB_VERSION}.zip -d /home/documentdb/code && \ | ||
| rm /tmp/v${DocumentDB_VERSION}.zip | ||
|
|
||
| #RUN wget -P /tmp https://github.com/documentdb/documentdb/archive/refs/tags/v${DocumentDB_VERSION}.zip && \ |
Collaborator
There was a problem hiding this comment.
can we remove commented code? We have version history so no need to retain
|
|
||
| WORKDIR /home/documentdb/gateway/scripts | ||
| #ENTRYPOINT ["/bin/bash", "-c", "/home/documentdb/gateway/scripts/emulator_entrypoint.sh \"$@\"", "--"] No newline at end of file | ||
| ENTRYPOINT ["/bin/bash", "-c", "/home/documentdb/gateway/scripts/emulator_entrypoint.sh \"$@\"", "--"] |
Collaborator
There was a problem hiding this comment.
I remember we had some issues and we commented it out. Now adding back. Do you remember why? Also, I prefer to make this type of changes in separate PR.
Collaborator
Author
There was a problem hiding this comment.
I don't remember an entrypoint issue, myself. We used this dockerfile to build and run a gateway image for testing and it seemed to work fine
hossain-rayhan
approved these changes
Jan 7, 2026
move scripts to proper folder Add telemetry scripts try new docker image adjust dockerfiles change to local build dockerfile Add telemetry deployment option add final demo touches
move to new folder and add docs Signed-off-by: Alexander Laye <alaye@microsoft.com> adjust scripts fix deploy location add backup resource delete commented code revert to pulling the archive instead of using local docdb
alaye-ms
force-pushed
the
telemetryScripts
branch
from
0007e8e to
098fc67
Compare
xgerman
approved these changes
Jan 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive telemetry and observability infrastructure for multi-cloud DocumentDB deployments. The changes include deployment scripts for OpenTelemetry collectors, Prometheus, and Grafana, along with various improvements to the multi-cloud deployment scripts and configuration parameterization.
Changes:
- Added telemetry deployment scripts and configuration for OpenTelemetry, Prometheus, and Grafana
- Standardized cluster naming from cloud-specific names (aks-documentdb-cluster, gke-documentdb-cluster, eks-documentdb-cluster) to simplified names (azure-documentdb, gcp-documentdb, aws-documentdb)
- Parameterized Docker images in deployment manifests to support custom image versions
- Updated OTEL collector endpoint configuration in operator code for distributed telemetry collection
- Enhanced error logging in DocumentDB controller and added credential secret parameter to CNPG plugin
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 27 comments.
Show a summary per file
| File | Description |
|---|---|
| operator/src/internal/controller/documentdb_controller.go | Improved error logging from Info to Error level for service creation failures |
| operator/src/internal/cnpg/cnpg_cluster.go | Added documentDbCredentialSecret parameter to plugin configuration |
| operator/cnpg-plugins/sidecar-injector/internal/lifecycle/lifecycle.go | Changed OTEL endpoint from localhost to cluster-wide service discovery |
| documentdb-playground/multi-cloud-deployment/telemetry/deploy-telemetry.sh | Main telemetry deployment script with OpenTelemetry operator, collectors, Prometheus, and Grafana |
| documentdb-playground/multi-cloud-deployment/telemetry/prometheus-values.yaml | Prometheus Helm values for multi-cloud metrics collection |
| documentdb-playground/multi-cloud-deployment/telemetry/grafana-values.yaml | Grafana Helm values with dashboard and datasource configuration |
| documentdb-playground/multi-cloud-deployment/telemetry/otel-collector.yaml | OpenTelemetry collector template for metrics pipeline |
| documentdb-playground/multi-cloud-deployment/telemetry/dashboard.json | Pre-built Grafana dashboard for DocumentDB monitoring |
| documentdb-playground/multi-cloud-deployment/main.bicep | Fixed fleet member naming to use memberName variable |
| documentdb-playground/multi-cloud-deployment/deploy.sh | Updated cluster names and Fleet version from v0.16.5 to v0.16.9 |
| documentdb-playground/multi-cloud-deployment/deploy-documentdb.sh | Added image parameterization, changed primary cluster selection, enhanced DNS configuration flexibility |
| documentdb-playground/multi-cloud-deployment/documentdb-cluster.yaml | Parameterized image versions and changed username from default_user to docdb |
| documentdb-playground/multi-cloud-deployment/documentdb-base.yaml | Added backup CRDs for db.microsoft.com |
| documentdb-playground/multi-cloud-deployment/dns_failover.sh | Updated GKE cluster name reference |
| documentdb-playground/multi-cloud-deployment/insert_test.py | Extended test duration from 10 to 60 minutes and reduced sleep interval |
| documentdb-playground/multi-cloud-deployment/README.md | Comprehensive documentation updates for new telemetry stack and cluster naming changes |
| documentdb-playground/aks-fleet-deployment/documentdb-resource-crp.yaml | Parameterized Docker images |
| documentdb-playground/aks-fleet-deployment/deploy-multi-region.sh | Added image parameterization support |
| .github/dockerfiles/Dockerfile_gateway | Added comment for local build workflow |
| .github/dockerfiles/Dockerfile_docdb | Changed libproj22 to libproj-dev |
documentdb-playground/multi-cloud-deployment/telemetry/grafana-values.yaml
Show resolved
Hide resolved
documentdb-playground/multi-cloud-deployment/telemetry/deploy-telemetry.sh
Outdated
Show resolved
Hide resolved
documentdb-playground/multi-cloud-deployment/telemetry/deploy-telemetry.sh
Show resolved
Hide resolved
documentdb-playground/multi-cloud-deployment/telemetry/deploy-telemetry.sh
Outdated
Show resolved
Hide resolved
documentdb-playground/multi-cloud-deployment/telemetry/deploy-telemetry.sh
Show resolved
Hide resolved
Signed-off-by: Alexander Laye <alaye@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.