Convert dict() calls to literals and improve typing with TypedDicts#224
Merged
seanthegeek merged 5 commits intomainfrom Dec 19, 2025
Merged
Convert dict() calls to literals and improve typing with TypedDicts#224seanthegeek merged 5 commits intomainfrom
seanthegeek merged 5 commits intomainfrom
Conversation
Co-authored-by: seanthegeek <44679+seanthegeek@users.noreply.github.com>
Co-authored-by: seanthegeek <44679+seanthegeek@users.noreply.github.com>
Co-authored-by: seanthegeek <44679+seanthegeek@users.noreply.github.com>
Co-authored-by: seanthegeek <44679+seanthegeek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor dict usage to typed dicts for compatibility
Convert dict() calls to literals and improve typing with TypedDicts
Dec 19, 2025
Contributor
|
@copilot Run tests.py and make sure al tests pass |
Contributor
Author
All tests pass ✓ (29 tests run, 2 skipped, 0 failures) Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
seanthegeek
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues typing work from PR #223 (dmarc.py) by converting all
dict()constructor calls to literal dictionaries and fixing TypedDict definitions across remaining modules to enable proper type checking.Changes
Dictionary constructor conversions (~60 instances)
dict()→{}dict(key=value)→{"key": value}dict([("key", value)])→{"key": value}TypedDict fixes and cast removal
SMTPTLSReportingTags: was single value TypedDict, nowdict[str, SMTPTLSReportingTagValue]MTASTSTags: was single value TypedDict, nowdict[str, str]ParsedMTASTSPolicy: field name "v" → "version" to match implementationType refinement
check_mta_sts:dict[str, Any]→MTASTSCheckResults(Union of success/failure TypedDicts)Python 3.9 compatibility
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.