Skip to content

Bump mlflow to 3.9 #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
niole wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Bump mlflow to 3.9 #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5060f34
Bump mlflow to 3.9
niole Feb 20, 2026
fab291b
Update tests
niole Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions domino/agents/_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# TODO update tag names to be prefixed with domino.agents in order to make origin clear
EVALUATION_TAG_PREFIX = "domino.prog"
DOMINO_INTERNAL_EVAL_TAG = "domino.internal.is_eval"
MIN_MLFLOW_VERSION = "3.2.0"
MIN_DOMINO_VERSION = "6.2.0"
MIN_MLFLOW_VERSION = "3.9.0"
MIN_DOMINO_VERSION = "6.3.0"
LARGEST_MAX_RESULTS_PAGE_SIZE = 500
EXPERIMENT_AGENT_TAG = "domino.agent"
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ def get_version():
"semver>=3.0.4",
"pandas>=2.3.1",
"numpy>=2.0.2",
"mlflow-skinny>=3.2.0,<3.3.0",
"mlflow-tracing>=3.2.0,<3.3.0",
"mlflow-skinny>=3.9.0,<3.10.0",
"mlflow-tracing>=3.9.0,<3.10.0",
],
"dev": [
"pytest-order>=1.3.0",
Expand Down
17 changes: 12 additions & 5 deletions tests/integration/agents/test_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,12 @@ def parent2(x):
assert sorted([(t.name, t.value) for trace in res.data for t in trace.evaluation_results if trace.name == "parent"]) \
== sorted([("mylabel", "category"), ("mymetric", 1.0)])
assert len(span_data) == 4
assert sorted(span_data, key=lambda x: x[0]) == sorted([("parent", {'x':1, 'y': 2}, 3), \
("parent2", {'x':1}, 1), ("unit_1", {'x':1}, 1), ("unit_2", {'x':2}, 2)
], key=lambda x: x[0])

expected_spans = [("parent", {'x':1, 'y': 2}, 3), \
Copy link
Contributor Author

@niole niole Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is that sibling spans with the same name no longer get _n suffixes, e.g unit_1 is now just unit

("unit", {'x':1}, 1), ("unit", {'x':2}, 2), ("parent2", {'x':1}, 1)]

for e in expected_spans:
assert e in span_data

def test_search_traces_time_filter_warning(setup_mlflow_tracking_server, tracing, mlflow, logging, caplog):
"""
Expand Down Expand Up @@ -555,8 +558,12 @@ def parent2(x):

assert [trace.name for trace in res.data] == ["parent"]
assert len(span_data) == 3
assert sorted(span_data, key=lambda x: x[0]) == sorted([("parent", {'x':1, 'y': 2}, 3), \
("unit_1", {'x':1}, 1), ("unit_2", {'x':2}, 2)], key=lambda x: x[0])

expected_spans = [("parent", {'x':1, 'y': 2}, 3), \
("unit", {'x':1}, 1), ("unit", {'x':2}, 2)]

for e in expected_spans:
assert e in span_data

def test_search_traces_by_timestamp(setup_mlflow_tracking_server, mocker, mlflow, tracing, logging):
@tracing.add_tracing(name="parent")
Expand Down