Audio editor refactoring after feedback #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bug where Audio Explorer wasn't playing music.
- Moved functions for stuff loading AudioProject Editor and Viewer data grids into NodeLoader.cs.
- Added AudioProjectEditor DataGrid services to better encapsulate node loading.
- Added label setting functions. - Fixed a bug where the Play Audio button in the AudioFilesExplorer wasn't working until an AudioProjectExplorer node had been selected. - Renaming.
- Added DataGrid services for AudioProjectViewer.
- Turned old DataService into AudioProjectDataService. - Added helper functions for getting selected node info. - Made better use of dependencies in data services and helpers.
- Renamed AudioProjectService to AudioEditorService. - Reorganisation of helpers. - Renaming.
- More refactoring.
- Implemented an event messaging system in place of NodeLoader.cs therefore separating the responsibilities to the view models they concern.
- Implemented event messaging for adding data to the audio project. - Changed events slightly and added data grid and selected node data to the audio editor service.
- Added event messaging for editing audio project items and removed the old DataManager.cs. - Moved removing audio project items logic into AudioProjectViewerViewModel. - Added AudioEditorViewModel to the AudioEditorService and updated affected functions.
- Improved accessing of view model data.
- Incorporated setting of data grid data into the services, rather than as helpers. - Fixed some bugs with audio settings enablement.
- Added audio settings for an individual sound. - Added visibility properties to audio settings so they are hidden when unused to reduce confusion. - Fixed a bug where audio settings weren't displaying correctly when selected from audio project viewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly reorganisation of files and addition of event messaging to handle processes across view models which allowed for much simpler data management logic so it's now split into the view models directly and their data grid services. Also fixed a few bugs.