chore(migration): Migration to self-closing tags #34063
Conversation
|
Semgrep found 23
Risk: Affected versions of @angular/compiler are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting'). A stored XSS vulnerability in the Angular Template Compiler arises because its internal security schema doesn't classify certain URL‐ holding attributes (e.g. xlink:href, math|href, annotation|href) or the Manual Review Advice: A vulnerability from this advisory is reachable if you allow Fix: Upgrade this library to at least version 20.3.15 at core/core-web/yarn.lock:557. Reference(s): GHSA-v4hv-rgfq-gp49, CVE-2025-66412 If this is a critical or high severity finding, please also link this issue in the #security channel in Slack. |
There was a problem hiding this comment.
Pull request overview
This pull request migrates Angular template files across the dotCMS codebase to use self-closing tag syntax for standalone components and elements. The migration is purely syntactic, aligning with modern Angular best practices for component usage, with no functional or behavioral changes introduced.
Key Changes:
- Converted component tags to self-closing syntax (e.g.,
<component></component>→<component />) - Applied to PrimeNG components (p-button, p-dropdown, p-menu, p-skeleton, etc.)
- Applied to custom dotCMS components (dot-icon, dot-spinner, dot-asset-search, etc.)
- Applied to Angular built-in directives (ng-content, ng-container, router-outlet, ng-template)
Reviewed changes
Copilot reviewed 239 out of 239 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Multiple .html template files across libs/ |
Migrated component tags to self-closing syntax for UI library components |
Multiple .html template files in template-builder/ |
Updated template builder component templates to use self-closing tags |
Multiple .html template files in sdk/angular/ |
Converted block editor and renderer components to self-closing syntax |
Multiple .html template files in portlets/ |
Updated portlet component templates across edit-ema, experiments, locales, analytics, content-drive, and usage modules |
Multiple .html template files in edit-content/ |
Migrated content editing field and form components to self-closing tags |
Multiple .html template files in block-editor/ |
Updated block editor extension and node components |
Multiple .html template files in dot-rules/ |
Converted rules engine components to self-closing syntax |
Multiple .ts component files with inline templates |
Updated inline template strings to use self-closing tags |
Multiple .html template files in apps/dotcms-ui/ |
Migrated application-level component templates including login, navigation, portlets, and content type editors |
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. GPL-2.0 MPL-2.0 |
…gs' of github.com:dotCMS/core into 34062-task-migrate-angular-templates-to-self-closing-tags
…tions and streamline dependency management
…and enhance palette functionality
…add storybook migration summary
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nicobytes
deleted the
34062-task-migrate-angular-templates-to-self-closing-tags
branch
Proposed Changes
This pull request primarily updates Angular template files across several apps to use self-closing tags for standalone components and elements, improving code consistency and readability. There are no functional or logic changes—these are purely syntactic updates to align with Angular best practices for self-closing components.
The most important changes are:
Template Syntax Consistency:
p-dropdown,p-skeleton,dot-icon,dot-spinner,p-chart,ng-container,p-avatar,dot-copy-link,p-button,p-menu,p-tableHeaderCheckbox, andp-sortIcon) to use self-closing syntax across thedotcdn,dotcms-block-editor, anddotcms-uiapps. This makes the codebase more consistent and easier to maintain. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]No business logic, UI, or behavioral changes are introduced—this is a purely structural and stylistic update.
Checklist
This PR fixes: #34062
This PR fixes: #34062