Allowing filtering by day in the Conversion #34167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

freddyDOTCMS wants to merge 1 commit into main from issue-34143-Conversion-cube-does-not-allow-range-day-filtering

+32 −25

Contributor

freddyDOTCMS commented Dec 24, 2025 •

edited by github-actions bot

Loading

Proposed Changes

The problems really was the max(day) in the first query, so that is why now I include a inner and a outer query here

https://github.com/dotCMS/core/compare/issue-34143-Conversion-cube-does-not-allow-range-day-filtering?expand=1#diff-2d6ea402f26a3e1feb87dfb3911a3e17fe1f9fecdc310067d2238a9838b18172R9-R25

Also I got some error by ambiguous fields

https://github.com/dotCMS/core/compare/issue-34143-Conversion-cube-does-not-allow-range-day-filtering?expand=1#diff-2d6ea402f26a3e1feb87dfb3911a3e17fe1f9fecdc310067d2238a9838b18172R73-R78

It fix an error in the way the total conversion is calculated

https://github.com/dotCMS/core/compare/issue-34143-Conversion-cube-does-not-allow-range-day-filtering?expand=1#diff-2d6ea402f26a3e1feb87dfb3911a3e17fe1f9fecdc310067d2238a9838b18172R85-R90

This PR fixes: #34143


          Allowing filtering by day in the Conversion

10d166b

freddyDOTCMS enabled auto-merge

December 24, 2025 18:11

github-actions bot mentioned this pull request

[DEFECT] Conversion cube does not allow range day filtering #34143

Open

jcastro-dotcms approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet