Don't hardcode values #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotaxis
requested changes
Feb 29, 2024
| PROTON_ID="1887720" | ||
| RUNTIME_VERSION="2.0" | ||
| RUNTIME_ID="1391110" | ||
| RUMTIME_NAME="soldier" |
Owner
There was a problem hiding this comment.
Can you rename this to RUNTIME_NAME?
| COMPAT_STRING="s/"CompatToolMapping"\\n\\s+{/"CompatToolMapping"\\n\\t\\t\\t\\t{\\n\\t\\t\\t\\t\\t"39140"\\n\\t\\t\\t\\t\\t{\\n\\t\\t\\t\\t\\t\\t"name"\\t\\t"proton_${PROTON_VERSION:0:1}"\\n\\t\\t\\t\\t\\t\\t"config"\\t\\t""\\n\\t\\t\\t\\t\\t\\t"priority"\\t\\t"250"\\n\\t\\t\\t\\t\\t}gs" | ||
|
|
||
| export STEAM_COMPAT_MOUNTS="$(getSteamLibrary ${PROTON_ID}):$(getSteamLibrary ${RUNTIME_ID}):$(getSteamLibrary 39140)" | ||
| PROTON=$(LIBRARY=$(getSteamLibrary ${PROTON_ID}) && [ -n "$LIBRARY" ] && echo "$LIBRARY/steamapps/common/Proton ${PROTON_VERSION}/proton" || echo "NONE") |
Owner
There was a problem hiding this comment.
We need to account for the use of Proton Experimental, in which the directory is named "Proton - Experimental."
If we set PROTON_VERSION to - Experimental this line will work, but line 39 and 75 will not look proper.
dotaxis
force-pushed
the
master
branch
2 times, most recently
from
4c2585d to
bf046c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also redid forcing the proton version in the config. It works for me but poke me on discord if you want something changed.