Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

DateTime parsing fixed on DateTimeUtils.TryParseDateRfc3339() #41

Open
ertugrulozcan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DateTime parsing fixed on DateTimeUtils.TryParseDateRfc3339() #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c437f
Extract method refactoring for fractional seconds removing
Jun 21, 2019
80cfbdd
Check dateTimeString length on RemoveFractionalSeconds method
Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions src/Utils/DateTimeUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,18 +234,8 @@ private static bool TryParseDateRfc3339(string dateTimeString, out DateTimeOffse
const string Rfc3339LocalDateTimeFormat = "yyyy-MM-ddTHH:mm:sszzz";
const string Rfc3339UTCDateTimeFormat = "yyyy-MM-ddTHH:mm:ssZ";

dateTimeString = dateTimeString.Trim();

if (dateTimeString[19] == '.')
{
// remove any fractional seconds, we choose to ignore them
int i = 20;
while (dateTimeString.Length > i && char.IsDigit(dateTimeString[i]))
{
++i;
}
dateTimeString = dateTimeString.Substring(0, 19) + dateTimeString.Substring(i);
}
// remove any fractional seconds, we choose to ignore them
dateTimeString = RemoveFractionalSeconds(dateTimeString);

DateTimeOffset localTime;
if (DateTimeOffset.TryParseExact(dateTimeString, Rfc3339LocalDateTimeFormat,
Expand All @@ -255,6 +245,7 @@ private static bool TryParseDateRfc3339(string dateTimeString, out DateTimeOffse
result = localTime;
return true;
}

DateTimeOffset utcTime;
if (DateTimeOffset.TryParseExact(dateTimeString, Rfc3339UTCDateTimeFormat,
CultureInfo.InvariantCulture.DateTimeFormat,
Expand All @@ -263,7 +254,29 @@ private static bool TryParseDateRfc3339(string dateTimeString, out DateTimeOffse
result = utcTime;
return true;
}

return false;
}

private static string RemoveFractionalSeconds(string dateTimeString)
{
dateTimeString = dateTimeString.Trim();

if (dateTimeString.Length < 20 || dateTimeString.IndexOf('.') < 0)
return dateTimeString;

if (dateTimeString[19] == '.')
{
int i = 20;
while (dateTimeString.Length > i && char.IsDigit(dateTimeString[i]))
{
++i;
}

dateTimeString = dateTimeString.Substring(0, 19) + dateTimeString.Substring(i);
}

return dateTimeString;
}
}
}