Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
2954a33
Add Maui iOS CoreCLR scenario benchmarks to the performance job pipeline
kotlarmilos Nov 3, 2025
b1da2d7
Add UseMonoRuntime property
kotlarmilos Nov 28, 2025
06ae6b0
Don't run pip libraries
kotlarmilos Dec 2, 2025
1a30450
Try install_versioned_maui
kotlarmilos Dec 2, 2025
980ff4b
Fix NuGet.config path
kotlarmilos Dec 2, 2025
b9f4bdc
Revert changes
kotlarmilos Dec 2, 2025
7ffbbb7
Revert changes
kotlarmilos Dec 10, 2025
e138be4
Test pip install
kotlarmilos Dec 10, 2025
c168ce3
Merge branch 'dotnet:main' into feature/maui-coreclr
kotlarmilos Dec 15, 2025
820b784
Update SDK version resolution logic
kotlarmilos Dec 15, 2025
553baf2
Add verbose flag to pip command
kotlarmilos Dec 15, 2025
3d304ab
Add support for externally-managed environments in pip installation
kotlarmilos Dec 15, 2025
9776ccf
Update Xcode version in MAUI iOS scenario command
kotlarmilos Dec 15, 2025
2aedb16
Update Xcode version in MAUI iOS scenario command
kotlarmilos Dec 15, 2025
515e18b
Refactor pip installation commands for externally-managed environments
kotlarmilos Dec 15, 2025
8237193
Add option to skip Xcode version validation in MAUI iOS scenario command
kotlarmilos Dec 15, 2025
d23f051
Add option to skip Xcode version validation in MAUI iOS scenario command
kotlarmilos Dec 15, 2025
86a96fd
Add MSBuild arguments to MAUI iOS scenario command
kotlarmilos Dec 15, 2025
a52dea8
Add verbose logging to MAUI iOS scenario command
kotlarmilos Dec 15, 2025
e0701c5
Update target framework version in ChannelMap to net10.0
kotlarmilos Dec 16, 2025
a9916f2
Update target framework version
kotlarmilos Dec 16, 2025
4ece98e
Remove logging
kotlarmilos Dec 16, 2025
5518867
Update Apple mobile SDK versions to 26.1.10642-ci.net11-0
kotlarmilos Dec 16, 2025
dc36def
Fix target dependency
kotlarmilos Dec 16, 2025
112cf7a
Revert changes
kotlarmilos Dec 16, 2025
bb4508b
Update MacCatalyst, macOS, iOS, and tvOS SDK versions to 26.1.10555-c…
kotlarmilos Dec 16, 2025
f43963c
Add TargetsCurrent=true
kotlarmilos Dec 16, 2025
a033c20
Set SupportedOSPlatformVersion to 26.0 to avoid iOS 26.1 API linking …
kotlarmilos Dec 16, 2025
c9b515e
Remove SupportedOSPlatformVersion setting and update Xcode version in…
kotlarmilos Dec 16, 2025
fd65821
Don't run MAUI templates
kotlarmilos Dec 16, 2025
dcfbcf0
Comment out XHarnessAppBundleToTest for iOS Maui Default Template
kotlarmilos Dec 16, 2025
206ef41
Fix test command syntax in maui_scenarios_ios.proj for iOS device sta…
kotlarmilos Dec 16, 2025
b8775d1
Improve build process
kotlarmilos Dec 16, 2025
2cf22ef
Update src/scenarios/mauiios/pre.py
kotlarmilos Dec 16, 2025
545702b
Update msbuild arguments for CoreCLR Interpreter and NativeAOT condit…
kotlarmilos Dec 17, 2025
6444b55
Merge branch 'feature/maui-coreclr' of github.com:kotlarmilos/perform…
kotlarmilos Dec 17, 2025
6e7b6e5
Add .NET 11 iOS SDK dependencies and update previous versions
kotlarmilos Dec 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,37 +76,55 @@
<Uri>https://github.com/dotnet/android</Uri>
<Sha>1dcfb6f8779c33b6f768c996495cb90ecd729329</Sha>
</Dependency>
<Dependency Name="Microsoft.MacCatalyst.Sdk.net10.0_18.5" Version="18.5.10824-net10-rc.2">
<!-- .NET 11 iOS version(s) -->
<Dependency Name="Microsoft.MacCatalyst.Sdk.net10.0_26.1" Version="26.1.10555-ci.net11-0">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>1ebe913b290f8d1bc0f770eb07fa98b199b61e8f</Sha>
</Dependency>
<Dependency Name="Microsoft.macOS.Sdk.net10.0_26.1" Version="26.1.10555-ci.net11-0">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>1ebe913b290f8d1bc0f770eb07fa98b199b61e8f</Sha>
</Dependency>
<Dependency Name="Microsoft.iOS.Sdk.net10.0_26.1" Version="26.1.10555-ci.net11-0">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>1ebe913b290f8d1bc0f770eb07fa98b199b61e8f</Sha>
</Dependency>
<Dependency Name="Microsoft.tvOS.Sdk.net10.0_26.1" Version="26.1.10555-ci.net11-0">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>1ebe913b290f8d1bc0f770eb07fa98b199b61e8f</Sha>
</Dependency>
<!-- .NET 10 iOS version(s) -->
<Dependency Name="Microsoft.MacCatalyst.Sdk.net10.0_18.5" Version="18.5.10824-net10-rc.2" CoherentParentDependency="Microsoft.MacCatalyst.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>890175615f7762dfbc4f8555007aaf5bb4d75c8f</Sha>
</Dependency>
<Dependency Name="Microsoft.macOS.Sdk.net10.0_15.5" Version="15.5.10824-net10-rc.2">
<Dependency Name="Microsoft.macOS.Sdk.net10.0_15.5" Version="15.5.10824-net10-rc.2" CoherentParentDependency="Microsoft.macOS.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>890175615f7762dfbc4f8555007aaf5bb4d75c8f</Sha>
</Dependency>
<Dependency Name="Microsoft.iOS.Sdk.net10.0_18.5" Version="18.5.10824-net10-rc.2">
<Dependency Name="Microsoft.iOS.Sdk.net10.0_18.5" Version="18.5.10824-net10-rc.2" CoherentParentDependency="Microsoft.iOS.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>890175615f7762dfbc4f8555007aaf5bb4d75c8f</Sha>
</Dependency>
<Dependency Name="Microsoft.tvOS.Sdk.net10.0_18.5" Version="18.5.10824-net10-rc.2">
<Dependency Name="Microsoft.tvOS.Sdk.net10.0_18.5" Version="18.5.10824-net10-rc.2" CoherentParentDependency="Microsoft.tvOS.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>890175615f7762dfbc4f8555007aaf5bb4d75c8f</Sha>
</Dependency>
<!-- Previous .NET iOS version(s) -->
<!-- .NET 9 iOS version(s) -->
<!-- This is a subscription of the .NET 9 latest stable versions of our packages -->
<Dependency Name="Microsoft.MacCatalyst.Sdk.net9.0_26.0" Version="26.0.9754">
<Dependency Name="Microsoft.MacCatalyst.Sdk.net9.0_26.0" Version="26.0.9754" CoherentParentDependency="Microsoft.MacCatalyst.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>4177c9d9590857cfb2617fd7a7ef3d5e1de48ed3</Sha>
</Dependency>
<Dependency Name="Microsoft.macOS.Sdk.net9.0_26.0" Version="26.0.9754">
<Dependency Name="Microsoft.macOS.Sdk.net9.0_26.0" Version="26.0.9754" CoherentParentDependency="Microsoft.macOS.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>4177c9d9590857cfb2617fd7a7ef3d5e1de48ed3</Sha>
</Dependency>
<Dependency Name="Microsoft.iOS.Sdk.net9.0_26.0" Version="26.0.9754">
<Dependency Name="Microsoft.iOS.Sdk.net9.0_26.0" Version="26.0.9754" CoherentParentDependency="Microsoft.iOS.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>4177c9d9590857cfb2617fd7a7ef3d5e1de48ed3</Sha>
</Dependency>
<Dependency Name="Microsoft.tvOS.Sdk.net9.0_26.0" Version="26.0.9754">
<Dependency Name="Microsoft.tvOS.Sdk.net9.0_26.0" Version="26.0.9754" CoherentParentDependency="Microsoft.tvOS.Sdk.net10.0_26.1">
<Uri>https://github.com/dotnet/macios</Uri>
<Sha>4177c9d9590857cfb2617fd7a7ef3d5e1de48ed3</Sha>
</Dependency>
Expand Down
25 changes: 18 additions & 7 deletions eng/performance/maui_scenarios_ios.proj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,16 @@
<PreparePayloadWorkItemBaseDirectory Condition="'$(TargetsWindows)' == 'true'">$(CorrelationPayloadDirectory)$(PreparePayloadOutDirectoryName)\</PreparePayloadWorkItemBaseDirectory>
<PreparePayloadWorkItemBaseDirectory Condition="'$(TargetsWindows)' != 'true'">$(CorrelationPayloadDirectory)$(PreparePayloadOutDirectoryName)/</PreparePayloadWorkItemBaseDirectory>

<NativeAOTCommandProps Condition="'$(RuntimeFlavor)' == 'coreclr'">--nativeaot true</NativeAOTCommandProps>
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'mono'">/p:UseMonoRuntime=true</_MSBuildArgs>
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">/p:UseMonoRuntime=false</_MSBuildArgs>

<!-- Mono FullAOT and CoreCLR R2R are considered as default configurations, so no need for explicit properties -->

<!-- CoreCLR Interpreter -->
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(CodegenType)' == 'Interpreter'">$(_MSBuildArgs);/p:PublishReadyToRun=false</_MSBuildArgs>
<!-- CoreCLR NativeAOT -->
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(CodegenType)' == 'NativeAOT'">$(_MSBuildArgs);/p:PublishAot=true;/p:PublishAotUsingRuntimePack=true</_MSBuildArgs>

</PropertyGroup>

<Target Name="RemoveDotnetFromCorrelationStaging" BeforeTargets="BeforeTest">
Expand All @@ -32,7 +41,8 @@
<IPAName>NetiOSDefault</IPAName>
<PackageName>com.companyname.NetiOSDefault</PackageName>
</MAUIiOSScenario>
<MAUIiOSScenario Include="Maui iOS Default Template">
<!-- TODO: Enable Maui iOS Default Template once https://github.com/dotnet/performance/issues/5055 is resolved -->
<!-- <MAUIiOSScenario Include="Maui iOS Default Template">
<ScenarioDirectoryName>mauiios</ScenarioDirectoryName>
<PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
<IPAName>MauiiOSDefault</IPAName>
Expand All @@ -43,12 +53,12 @@
<PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
<IPAName>MauiBlazoriOSDefault</IPAName>
<PackageName>net.dot.mauiblazortesting</PackageName>
</MAUIiOSScenario>
</MAUIiOSScenario> -->
</ItemGroup>

<ItemGroup>
<PreparePayloadWorkItem Include="@(MAUIiOSScenario)">
<Command>sudo xcode-select -s /Applications/Xcode_26.0.1.app; $(Python) pre.py publish -f $(PERFLAB_Framework)-ios --self-contained -c Release -r ios-arm64 $(NativeAOTCommandProps) --binlog $(PreparePayloadWorkItemBaseDirectory)%(PreparePayloadWorkItem.ScenarioDirectoryName)/%(PreparePayloadWorkItem.ScenarioDirectoryName).binlog -o $(PreparePayloadWorkItemBaseDirectory)%(PreparePayloadWorkItem.ScenarioDirectoryName); cd ../; zip -r %(PreparePayloadWorkItem.ScenarioDirectoryName).zip %(PreparePayloadWorkItem.ScenarioDirectoryName)</Command>
<Command>sudo xcode-select -s /Applications/Xcode_26.1.1.app; $(Python) pre.py publish -f $(PERFLAB_Framework)-ios --self-contained -c Release -r ios-arm64 --msbuild=&quot;$(_MSBuildArgs)&quot; --binlog $(PreparePayloadWorkItemBaseDirectory)%(PreparePayloadWorkItem.ScenarioDirectoryName)/%(PreparePayloadWorkItem.ScenarioDirectoryName).binlog -o $(PreparePayloadWorkItemBaseDirectory)%(PreparePayloadWorkItem.ScenarioDirectoryName); cd ../; zip -r %(PreparePayloadWorkItem.ScenarioDirectoryName).zip %(PreparePayloadWorkItem.ScenarioDirectoryName)</Command>
<WorkingDirectory>%(PreparePayloadWorkItem.PayloadDirectory)</WorkingDirectory>
</PreparePayloadWorkItem>
</ItemGroup>
Expand Down Expand Up @@ -94,7 +104,8 @@
]]>
</CustomCommands>
</XHarnessAppBundleToTest>
<XHarnessAppBundleToTest Include="Device Startup - iOS Maui Default Template">
<!-- TODO: Enable Device Startup - iOS Maui Default Template once https://github.com/dotnet/performance/issues/5055 is resolved -->
<!-- <XHarnessAppBundleToTest Include="Device Startup - iOS Maui Default Template">
<AppBundlePath>$(ScenariosDir)mauiios.zip</AppBundlePath>
<WorkItemTimeout>00:15:00</WorkItemTimeout>
<TestTarget>ios-device</TestTarget>
Expand All @@ -113,15 +124,15 @@
sign MauiiOSDefault.app

# Testing commands
$(Python) test.py devicestartup --device-type ios --package-path MauiiOSDefault.app --package-name net.dot.mauitesting --scenario-name "%(Identity)" $(ScenarioArgs)
$(Python) test.py devicestartup -1-device-type ios -1-package-path MauiiOSDefault.app -1-package-name net.dot.mauitesting -1-scenario-name "%(Identity)" $(ScenarioArgs)
((result=$?))

# Post commands
$(Python) post.py
exit $result
]]>
</CustomCommands>
</XHarnessAppBundleToTest>
</XHarnessAppBundleToTest> -->
<!-- Now also disabled for normal mono runs. (Reenable for mono and native aot once fixed). Tracking issue: https://github.com/dotnet/performance/issues/3148 -->
<!-- <XHarnessAppBundleToTest Condition="'$(RuntimeFlavor)' == 'mono'" Include="Device Startup - iOS Maui Blazor Default Template">
<AppBundlePath>$(ScenariosDir)mauiblazorios.zip</AppBundlePath>
Expand Down
18 changes: 18 additions & 0 deletions eng/pipelines/sdk-perf-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,24 @@ jobs:
${{ each parameter in parameters.jobParameters }}:
${{ parameter.key }}: ${{ parameter.value }}

# Maui iOS CoreCLR scenario benchmarks
- template: /eng/pipelines/templates/build-machine-matrix.yml
parameters:
jobTemplate: /eng/pipelines/templates/run-scenarios-job.yml
buildMachines:
- osx-x64-ios-arm64
isPublic: false
jobParameters:
runKind: maui_scenarios_ios
projectFileName: maui_scenarios_ios.proj
channels:
- main
runtimeFlavor: coreclr
codeGenType: Interpreter
additionalJobIdentifier: CoreCLR
${{ each parameter in parameters.jobParameters }}:
${{ parameter.key }}: ${{ parameter.value }}

# Maui iOS Native AOT scenario benchmarks
- template: /eng/pipelines/templates/build-machine-matrix.yml
parameters:
Expand Down
5 changes: 5 additions & 0 deletions scripts/channel_map.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ class ChannelMap():
'branch': '10.0',
'quality': 'daily'
},
'nativeaot11.0': {
'tfm': 'nativeaot11.0',
'branch': '11.0',
'quality': 'daily'
},
'9.0': {
'tfm': 'net9.0',
'branch': '9.0',
Expand Down
5 changes: 3 additions & 2 deletions scripts/dotnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,9 @@ def get_dotnet_version_from_path(
sdk = next((f for f in sdks if f.startswith(
"{}.{}".format(version.major, version.minor + 1))), None)
if not sdk:
if version.major == 9:
sdk = next((f for f in sdks if f.startswith("10.0")), None)
# Attempt 3: Try to use SDK with major version + 1 (e.g., net9.0 -> SDK 10.0, net10.0 -> SDK 11.0).
sdk = next((f for f in sdks if f.startswith(
"{}.{}".format(version.major + 1, version.minor))), None)
if not sdk:
sdk = next((f for f in sdks if f.startswith(
"{}.{}".format('6', '0'))), None)
Expand Down
7 changes: 4 additions & 3 deletions scripts/run_performance_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -1010,9 +1010,10 @@ def publish_dotnet_app_to_payload(payload_dir_name: str, csproj_path: str, self_

# TODO: See if these commands are needed for linux as they were being called before but were failing.
if args.os_group == "windows" or args.os_group == "osx":
RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", "--user", "--upgrade", "pip"]).run()
RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", "--user", "urllib3==1.26.19"]).run()
RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", "--user", "requests"]).run()
break_system_packages = ["--break-system-packages"] if args.os_group == "osx" else []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To double check, the new --break-system-packages will hopefully allow these calls to succeed on OSX because without it we get an error about the environment being externally managed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it fixes the failures in #5054

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we don't create a python environment (venv) and instead we use the global system python? cc: @LoopedBard3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should be using a venv looking at the logs from the runs, so maybe there is just a different interaction on OSX that causes the error to still show up despite being in a venv. Here is part of the installing prereqs near the top of job from the test run:

+ export ORIGPYPATH=:/etc/helix/scripts
+ ORIGPYPATH=:/etc/helix/scripts
+ echo '** Installing prerequistes **'
** Installing prerequistes **
+ python3 -m venv /tmp/helix/working/B7720975/w/9D7D093E/e/.venv
+ . /tmp/helix/working/B7720975/w/9D7D093E/e/.venv/bin/activate
++ deactivate nondestructive
++ '[' -n '' ']'
++ '[' -n '' ']'
++ '[' -n /bin/sh -o -n '' ']'
++ hash -r
++ '[' -n '' ']'
++ unset VIRTUAL_ENV
++ '[' '!' nondestructive = nondestructive ']'
++ VIRTUAL_ENV=/tmp/helix/working/B7720975/w/9D7D093E/e/.venv
++ export VIRTUAL_ENV
++ _OLD_VIRTUAL_PATH=/usr/bin:/bin:/usr/sbin:/sbin
++ PATH=/tmp/helix/working/B7720975/w/9D7D093E/e/.venv/bin:/usr/bin:/bin:/usr/sbin:/sbin
++ export PATH
++ '[' -n '' ']'
++ '[' -z '' ']'
++ _OLD_VIRTUAL_PS1=
++ PS1='(.venv) '
++ export PS1
++ '[' -n /bin/sh -o -n '' ']'
++ hash -r
+ export PYTHONPATH=
+ PYTHONPATH=
+ python -m pip install -U pip
Requirement already satisfied: pip in ./.venv/lib/python3.9/site-packages (21.2.4)
Collecting pip
  Using cached pip-25.3-py3-none-any.whl (1.8 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 21.2.4
    Uninstalling pip-21.2.4:
      Successfully uninstalled pip-21.2.4
Successfully installed pip-25.3
+ python -m pip install azure.storage.blob==12.13.0
Collecting azure.storage.blob==12.13.0
  Using cached azure_storage_blob-12.13.0-py3-none-any.whl.metadata (25 kB)
Collecting azure-core<2.0.0,>=1.23.1 (from azure.storage.blob==12.13.0)

RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", *break_system_packages, "--user", "--upgrade", "pip"]).run()
RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", *break_system_packages, "--user", "urllib3==1.26.19"]).run()
RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", *break_system_packages, "--user", "requests"]).run()

scenarios_path = os.path.join(args.performance_repo_dir, "src", "scenarios")
script_path = os.path.join(args.performance_repo_dir, "scripts")
Expand Down
3 changes: 2 additions & 1 deletion src/scenarios/mauiblazorios/pre.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
''')

# Build the IPA - will use merged NuGet.config
precommands.execute(['/p:EnableCodeSigning=false', '/p:ApplicationId=net.dot.mauiblazortesting'])
# TODO: Remove /p:TargetsCurrent=true once https://github.com/dotnet/performance/issues/5055 is resolved
precommands.execute(['/p:EnableCodeSigning=false', '/p:ApplicationId=net.dot.mauiblazortesting', '/p:TargetsCurrent=true'])
# NuGet.config is automatically restored after this block

output_dir = const.PUBDIR
Expand Down
5 changes: 3 additions & 2 deletions src/scenarios/mauiios/pre.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
working_directory=sys.path[0],
no_restore=False)

# Build the IPA - will also use merged NuGet.config
precommands.execute(['/p:EnableCodeSigning=false', '/p:ApplicationId=net.dot.mauitesting'])
# Build the IPA - will use merged NuGet.config
# TODO: Remove /p:TargetsCurrent=true once https://github.com/dotnet/performance/issues/5055 is resolved
precommands.execute(['/p:EnableCodeSigning=false', '/p:ApplicationId=net.dot.mauitesting', '/p:TargetsCurrent=true'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct spacing?

# NuGet.config is automatically restored after this block

# Remove the aab files as we don't need them, this saves space
Expand Down
5 changes: 3 additions & 2 deletions src/scenarios/netios/pre.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
working_directory=sys.path[0],
no_restore=False)

# Build the APK
precommands.execute(['/p:EnableCodeSigning=false', '/p:ApplicationId=net.dot.xamarintesting'])
# Build the IPA - will use merged NuGet.config
# TODO: Remove /p:TargetsCurrent=true once https://github.com/dotnet/performance/issues/5055 is resolved
precommands.execute(['/p:EnableCodeSigning=false', '/p:ApplicationId=net.dot.xamarintesting', '/p:TargetsCurrent=true'])

# Remove the aab files as we don't need them, this saves space
output_dir = const.PUBDIR
Expand Down
8 changes: 0 additions & 8 deletions src/scenarios/shared/precommands.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ def __init__(self):
self.operation = args.operation
self.framework = args.framework
self.runtime_identifier = args.runtime
self.nativeaot = args.nativeaot
self.msbuild = args.msbuild
print(self.msbuild)
self.msbuildstatic = args.msbuildstatic
Expand Down Expand Up @@ -154,10 +153,6 @@ def add_common_arguments(self, parser: ArgumentParser):
dest='runtime',
metavar='runtime',
help='runtime for build or publish - ex: win-x64')
parser.add_argument('-n', '--nativeaot',
dest='nativeaot',
metavar='nativeaot',
help='use Native AOT runtime for build or publish')
parser.add_argument('--msbuild',
dest='msbuild',
metavar='msbuild',
Expand Down Expand Up @@ -211,9 +206,6 @@ def execute(self, build_args: list[str] = []):
build_args.append('--self-contained')
elif self.no_self_contained:
build_args.append('--no-self-contained')
if self.nativeaot:
build_args.append('/p:PublishAot=true')
build_args.append('/p:PublishAotUsingRuntimePack=true')
build_args.append("/p:EnableWindowsTargeting=true")
self._publish(configuration=self.configuration, runtime_identifier=self.runtime_identifier, framework=self.framework, output=self.output, build_args=build_args)
if self.operation == CROSSGEN:
Expand Down
Loading