Better codegen for record's Equals member#79966
Better codegen for record's Equals member#79966DoctorKrolic wants to merge 7 commits intodotnet:mainfrom
Equals member#79966Conversation
…ypes in synthesized records' `Equals` methods
jaredpar
left a comment
There was a problem hiding this comment.
Putting a hold on the PR until the underlying issue gets LDM sign off.
|
@jaredpar Do you have this question scheduled for an LDM? Correct me if I am wrong, but this is a weekly event, isn't it? I don't think it would take much discussion time to make a decision here |
Usually but not always.
No. Don't believe anyone has put this on the agenda. @RikkiGibson, @CyrusNajmabadi in case they have time to bring this in the next few weeks. |
|
I'll look into it. I don't find it hugely important. But if we have time, then sure:-) |
|
@CyrusNajmabadi for a friendly reminder |
|
Thanks for the reminder. Will try to bring to LDM soon. |
|
@CyrusNajmabadi @DoctorKrolic this PR by itself is not enough to bring to LDM. There needs to be an actual proposal checked into csharplang. |
|
You mean something like this? |
Closes #70221
One of comments in the issue also mentions
GetHashCode. I tried it locally (by "it" I mean callingGetHashCodedirectly when overriden in structs) and it turns out that it takes a bit more IL due to ceremony with constrained call, so I didn't include those changes