Add SetAction to dotnet nuget trust subcommands #52224
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug introduced in a previous refactoring (#51624) where the SetAction call was missing for all dotnet nuget trust subcommands (author, repository, source, certificate, remove, sync, and list). Without this action registration, the trust subcommands would fail to execute properly at runtime.
Key Changes:
- Restores the
SetAction(NuGetCommand.Run)call within the foreach loop that iterates over trust subcommands
tmat
left a comment
tmat
left a comment
There was a problem hiding this comment.
This is not a correct fix. The command definition shouldn't set actions. That should be done in NuGetCommandParser.SetAction. The bug is that it doesn't do it recursively.
BTW, are there no tests covering this command?
|
@tmat Pushed a change to do it recursively, and at the moment we don't have tests for this and other commands in this repo. We found this bug when our CI tests started failing. |
|
@tmat Tests passed, can we merge this? I just realized the PR is pointing main, is that the correct branch? |
Good catch - it should go to release/10.0.2xx. Please rebase. |
Fixes: #52220
In a previous refactoring PR #51624, there was a missing SetAction to dotnet nuget trust subcommands that broke them.