Skip to content

[SDPPE-200] Updated conditional to correctly check data type. #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GROwen merged 1 commit into from
Jan 14, 2026
Merged

[SDPPE-200] Updated conditional to correctly check data type. #413

GROwen merged 1 commit into from
Jan 14, 2026

Conversation

@GROwen
Copy link
Contributor

@GROwen GROwen commented Jan 13, 2026 •
edited
Loading

Motivation

Runs of the branch-sync workflow were posting notifications to Slack advising that conflicts existed where there were none.

Changes

  • Updated the conditional check for the step "Send Slack notification if pr created but conflicts exist" so that the test handles the string value of the CONFLICTS environment variable instead of treating it as a boolean.

@GROwen GROwen requested a review from nicksantamaria January 13, 2026 04:03
@GROwen GROwen self-assigned this Jan 13, 2026
@GROwen GROwen added the NEEDS REVIEW Good for newcomers label Jan 13, 2026
@GROwen GROwen merged commit 005dfd7 into 6.x Jan 14, 2026
1 check passed
@GROwen GROwen deleted the feature/SDPPE-200--fix-false-conflict-notification branch January 14, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicksantamaria nicksantamaria nicksantamaria approved these changes

Assignees

@GROwen GROwen

Labels

NEEDS REVIEW Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GROwen @nicksantamaria