[SDPPE-168] Set PHP db conn default collation. #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GROwen
requested review from
MdNadimHossain,
anthony-malkoun,
nicksantamaria and
vincent-gao
Contributor
|
/build |
Contributor
|
@GROwen do we want to wait for backend to test the |
Contributor
Author
|
@nicksantamaria I don't think it's necessary but we do need to bump the tag for mariadb. Lagoon's updated the naming convention to couple them specifically to MariaDB versions. I'll post a commit in a sec. |
GROwen
commented
Jan 23, 2026
| FROM uselagoon/mariadb-drupal:latest | ||
| FROM uselagoon/mariadb-10.11-drupal:latest | ||
|
|
||
| ENV MARIADB_CHARSET=latin1 |
Contributor
Author
There was a problem hiding this comment.
I've removed these values because they are set in the connection block in bay/settings.php, in the case of collation and in the case of the charset we should use the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Preparation for mysql 8 upgrade
Changes
Added mysql 5.7 compatible collation and avoids mix of collations.