Skip to content

Conversation

@jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 838cb24
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/67562410b7c5f4000814b002

@cypress
Copy link

cypress bot commented Dec 6, 2024

ripple-framework    Run #2449

Run Properties:  status check passed Passed #2449  •  git commit 0b6055093e: Merge pull request #1389 from dpc-sdp/feature/SD-387-new-relic-browser
Project ripple-framework
Branch Review 2.22.0
Run status status check passed Passed #2449
Run duration 09m 55s
Commit git commit 0b6055093e: Merge pull request #1389 from dpc-sdp/feature/SD-387-new-relic-browser
Committer dylankelly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@lambry lambry self-requested a review December 9, 2024 01:10
@lambry lambry marked this pull request as ready for review December 9, 2024 01:10
@lambry lambry added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit d428e69 Dec 9, 2024
8 checks passed
@lambry lambry deleted the release/2.22.0 branch December 9, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants