Skip to content

Conversation

@jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Jan 19, 2026

Issue:

What I did

  • Running typescript on the whole monorepo in one go was causing issues and making dealing with typescript errors difficult.
    • Running pnpm exec tsc --noEmit didn't pick up errors in vue components, for that we need vue-tsc
    • Running pnpm exec tsc --noEmit globally doesn't really work for the docs or examples/nuxt packages, it's better to use the builtin nuxt typecheck command for then as it knows about auto imports etc.
  • This PR adds a pnpm typecheck command to each of the UI packages
    • Run pnpm typecheck to type check all packages
    • Run pnpm -F @dpc-sdp/ripple-ui-core typecheck to just check specific packages
  • Typescript errors will get fixed in future PRs

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@jeffdowdle jeffdowdle changed the title chore: setup typecheck scripts for each ui package [SD-1526] - Setup typecheck scripts for each ui package Jan 19, 2026
@jeffdowdle jeffdowdle changed the title [SD-1526] - Setup typecheck scripts for each ui package chore: [SD-1526] - Setup typecheck scripts for each ui package Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants