Skip to content

chore: [SD-1526] - ripple-ui-form typescript cleanup #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeffdowdle wants to merge 7 commits into
base: chore/SD-1526-ts-refactor
Choose a base branch
from
Open

chore: [SD-1526] - ripple-ui-form typescript cleanup #1340

jeffdowdle wants to merge 7 commits into from
+187 −114

Conversation

@jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Jan 21, 2026 •
edited
Loading

Issue: https://digital-vic.atlassian.net/browse/SD-1526

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@jeffdowdle jeffdowdle changed the base branch from main to chore/SD-1526-ts-refactor January 21, 2026 02:00
@jeffdowdle jeffdowdle changed the title [SD-1526] - ripple-ui-core typescript cleanup [SD-1526] - ripple-ui-form typescript cleanup Jan 21, 2026
@jeffdowdle jeffdowdle changed the title [SD-1526] - ripple-ui-form typescript cleanup chore: [SD-1526] - ripple-ui-form typescript cleanup Jan 27, 2026
@jeffdowdle jeffdowdle marked this pull request as ready for review January 28, 2026 02:07
@jeffdowdle jeffdowdle requested a review from a team as a code owner January 28, 2026 02:07
@jeffdowdle jeffdowdle requested review from lambry and waitingallday and removed request for a team January 28, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lambry lambry Awaiting requested review from lambry lambry is a code owner automatically assigned from dpc-sdp/dgs-frontend

@waitingallday waitingallday Awaiting requested review from waitingallday waitingallday is a code owner automatically assigned from dpc-sdp/dgs-frontend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffdowdle