Wayland backend: Add XDG Dialog protocol, and handle WidgetType::Dialog#58
Merged
dpjudas merged 3 commits intodpjudas:masterfrom Feb 4, 2026
Merged
Wayland backend: Add XDG Dialog protocol, and handle WidgetType::Dialog#58dpjudas merged 3 commits intodpjudas:masterfrom
dpjudas merged 3 commits intodpjudas:masterfrom
Conversation
- Turn toplevel windows into XDG Dialogs when the protocol is available - Also rename m_AppSurface to m_WindowSurface as it makes more sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds XDG-Dialog_v1 protocol support to Wayland backend and when the said protocol is available, uses it to handle the new
WidgetType::Dialogenum.That said, this only marks the toplevels as dialogs so that the compositors recognize them as such (i.e. if you mark the XDG-Dialog'd Toplevel as modal on KDE it will dim the dialog's parent window a lil bit). It doesn't handle any dialog logic.
I also renamed
m_AppSurfacetom_WindowSurfaceonWaylandDisplayWindowas it makes more sense.