Fix parameter validation to reject over-limit values instead of clamping#94
Merged
moltude merged 2 commits intofix/api-phase-2from Dec 9, 2025
Merged
Fix parameter validation to reject over-limit values instead of clamping#94moltude merged 2 commits intofix/api-phase-2from
moltude merged 2 commits intofix/api-phase-2from
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: moltude <1419766+moltude@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP address feedback from review on API improvements
Fix parameter validation to reject over-limit values instead of clamping
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 502 in
ParamValidator.scalaclamped values exceeding max limits instead of throwing exceptions, contradicting the updated test expectations that require rejection.Change:
validIntWithRange: Changedelse if (int > max) maxtoelse if (int > max) throw ValidationException(rule)Context:
When max limits were reduced (e.g.,
maxPageSize500→100), tests were updated to expectInvalidSearchParamsfor over-limit values, but the implementation still silently clamped to max.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.