Skip to content

Updated logical test#15

Merged
mdellabitta merged 2 commits intomainfrom
spark-test-update
Jan 2, 2025
Merged

Updated logical test#15
mdellabitta merged 2 commits intomainfrom
spark-test-update

Conversation

@mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Jan 2, 2025

Important

Update build configuration and refactor TestIds.scala to use HttpClient and improve error handling.

  • Build Configuration:
    • Update Scala version to 2.12.12 and organization to dp.la in build.sbt.
    • Set SPARK_VERSION to 3.5.3 and update Spark dependencies in build.sbt.
    • Update sbt.version to 1.10.7 in build.properties.
  • TestIds.scala Refactoring:
    • Replace scalaj.http with java.net.http.HttpClient for HTTP requests.
    • Add checkIds() and checkId() functions for processing IDs and handling HTTP responses.
    • Implement countBytes() to calculate response body size.
    • Introduce Result case class for structured result handling.
    • Improve error handling and logging for HTTP requests.

This description was created by Ellipsis for baa9466. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 25a4d39 in 1 minute and 31 seconds

More details
  • Looked at 148 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_YmZSBrSHqf0rJdxY


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on baa9466 in 31 seconds

More details
  • Looked at 36 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_hOGpPQwCuP6pAv41


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

@mdellabitta mdellabitta merged commit 1d290dc into main Jan 2, 2025
5 checks passed
@mdellabitta mdellabitta deleted the spark-test-update branch January 2, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant