[Relocatable] Follow-up 9: Harden processing of SOURCE_DATE_EPOCH in ocamldoc
#226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
added
no-change-entry-needed
dra27
changed the title
SOURCE_DATE_EPOCH in ocamldocSOURCE_DATE_EPOCH in ocamldoc
dra27
force-pushed
the
relocatable-testing
branch
from
3c8b5c1 to
2a7e0ad
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
09a330f to
efc6aa5
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
efc6aa5 to
aa27102
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
8e026d6 to
1fdb99f
Compare
dra27
force-pushed
the
relocatable-testing
branch
from
d644c59 to
63922b2
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
1fdb99f to
2034bb7
Compare
dra27
force-pushed
the
relocatable-testing
branch
from
63922b2 to
198fcfd
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
2034bb7 to
e9dcea5
Compare
dra27
force-pushed
the
relocatable-testing
branch
from
198fcfd to
56b115d
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
e9dcea5 to
ea7d6b7
Compare
Previously, running: SOURCE_DATE_EPOCH= ocamldoc resulted in an uncaught Failure "float_of_string" exception. The processing of SOURCE_DATE_EPOCH is firstly hardened to cope with parsing errors and then a one-time warning is displayed the first time it's actually used (at present it's only required in Odoc_man).
dra27
force-pushed
the
relocatable-testing
branch
from
56b115d to
5c4d9f3
Compare
dra27
force-pushed
the
ocamldoc-epoch
branch
from
ea7d6b7 to
6cfb6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running:
SOURCE_DATE_EPOCH= ocamldoc
resulted in an uncaught Failure "float_of_string" exception. The processing of SOURCE_DATE_EPOCH is firstly hardened to cope with parsing errors and then a one-time warning is displayed the first time it's actually used (at present it's only required in Odoc_man).