[Relocatable] Follow-up 22: Improve error message when dynamic loading is unexpectedly unavailable #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
added
relocatable
dra27
changed the title
dra27
force-pushed
the
relocatable-testing
branch
from
3c8b5c1 to
2a7e0ad
Compare
dra27
force-pushed
the
loading-errors
branch
from
aa49888 to
4863080
Compare
dra27
force-pushed
the
loading-errors
branch
from
4863080 to
b9b5fbc
Compare
dra27
force-pushed
the
loading-errors
branch
from
f2911bd to
2e6522a
Compare
dra27
force-pushed
the
relocatable-testing
branch
from
d644c59 to
63922b2
Compare
dra27
force-pushed
the
loading-errors
branch
from
2e6522a to
906a78a
Compare
dra27
force-pushed
the
relocatable-testing
branch
from
63922b2 to
198fcfd
Compare
dra27
force-pushed
the
loading-errors
branch
from
906a78a to
5d0fd78
Compare
dra27
force-pushed
the
relocatable-testing
branch
from
198fcfd to
56b115d
Compare
dra27
force-pushed
the
loading-errors
branch
from
5d0fd78 to
f574339
Compare
Exposes the value of SUPPORT_DYNAMIC_LINKING.
It is possible, especially when using Dynlink, to end up in the situation where a bytecode runtime which doesn't support dynamic loading is asked to load support DLLs (e.g. a bytecode image with a DLLS section, or a cma archive passed to the toplevel/Dynlink which has a non-empty lib_dllibs list). Previously, the error message would refer to the name of the first DLL being loaded and simply state that dynamic loading is not supported. The confusing part is that typically this would refer to a DLL which is not on the system. Now, the bytecode linker only writes DLLS and DLPT when there are entries to write in them, and the runtime, toplevel and Dynlink provide a direct explanation that dynamic loading is needed, but is not available. In particular, the error now refers to the file which is being loaded (i.e. the bytecode executable or the .cma file) rather than a .so file which doesn't exist.
dra27
force-pushed
the
relocatable-testing
branch
from
56b115d to
5c4d9f3
Compare
dra27
force-pushed
the
loading-errors
branch
from
f574339 to
c96b6cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.