-
Notifications
You must be signed in to change notification settings - Fork 5
Update legacy syntax #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe notification daemon configuration was updated to modify the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to configuration file format updates. ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
dunstrc (1)
35-37: Same compatibility caveat applies tooffset; ensure all hosts run ≥ 1.12.
offset = (10, 50)is ignored by earlier releases that still expect the legacy10x50form.
Consider leaving a brief inline comment noting the minimum required Dunst version to prevent confusion for future maintainers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
dunstrc(1 hunks)
🔇 Additional comments (1)
dunstrc (1)
29-31: Confirm runtime Dunst version supports tuple syntax forheight.Tuple notation (
(min, max)) forheightis only parsed correctly starting from v1.12.0.
If this config might be used on mixed environments (older distro packages, remote hosts, etc.), double-check that every target machine runs ≥ 1.12, otherwise notifications will silently fall back to the compiled default and appear unexpectedly tall.
Updated the height and offset settings to match with changes implemented in Dunst v1.12.0. This will help to reduce potential errors by using the preferred syntax.